applications: serial_lte_modem: Fix asserts when pressing power pin #21081
+55
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: e21f687de5212f75dd5d2d666f29340c848f085e more detailssdk-nrf:
Github labels
List of changed files detected by CI (2)Outputs:ToolchainVersion: 4ffa2202d5 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
trantanen
force-pushed
the
slm_powerpin_assert
branch
from
c3bf395 to
47c081e
Compare
trantanen
commented
Mar 21, 2025
trantanen
commented
Mar 21, 2025
|
You can find the documentation preview for this PR here. |
SeppoTakalo
approved these changes
Mar 21, 2025
trantanen
force-pushed
the
slm_powerpin_assert
branch
from
47c081e to
466eb13
Compare
trantanen
force-pushed
the
slm_powerpin_assert
branch
from
466eb13 to
e1fb005
Compare
|
trantanen
force-pushed
the
slm_powerpin_assert
branch
from
e1fb005 to
616dd78
Compare
rlubos
approved these changes
Mar 24, 2025
MarkusLassila
approved these changes
Mar 24, 2025
Asserts were enabled with PR nrfconnect#20040. This has caused an assert to occur when pressing power pin, because GPIO callback (power_pin_callback_wakeup) called slm_at_host_power_on, which called k_sleep(), which has an assert that it's not called from interrupt context. Added most of the wake up operation into a worker. Jira: LRCS-70 Signed-off-by: Tommi Rantanen <tommi.rantanen@nordicsemi.no>
Add command for toggling power pin. Also adding main command for operations done in SLM shell device. Toggling is done as follows: "slmsh powerpin" Jira: LRCS-84 Signed-off-by: Tommi Rantanen <tommi.rantanen@nordicsemi.no>
trantanen
force-pushed
the
slm_powerpin_assert
branch
from
616dd78 to
e21f687
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asserts were enabled with PR #20040.
This has caused an assert to occur when pressing power pin, because GPIO callback (
power_pin_callback_wakeup()) calledslm_at_host_power_on(), which calledk_sleep(), which has an assert that it's not called from interrupt context. Added most of the wake up operation into a worker.Also added a command to
modem_slmlibrary for toggling power pin. In addition, adding main command for operations done in SLM shell device. Toggling power pin is done as follows:"slmsh powerpin"
I have some follow-up PRs for SLM shell so I'll also update its documentation then regarding the new command. I'd like to get these changes in whenever they are technically OK so that test engineers can proceed testing the power pin.
Jira: LRCS-70
Jira: LRCS-84